Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User ID uses "visitorId" in the doc #258

Closed
mattab opened this issue Jun 28, 2018 · 5 comments · Fixed by #268
Closed

User ID uses "visitorId" in the doc #258

mattab opened this issue Jun 28, 2018 · 5 comments · Fixed by #268

Comments

@mattab
Copy link
Member

mattab commented Jun 28, 2018

we noticed in the "User ID" readme that it says "matomoTracker.visitorId" (See: https://github.com/matomo-org/matomo-sdk-ios#custom-user-id)

-> would it be possible to also use "matomoTracker.userId" instead maybe for consistency?

@brototyp
Copy link
Member

brototyp commented Jul 2, 2018

Hi @mattab, thanks for the hint and your suggestion 🙇.

Let's

  • rename the visitorId property of the MatomoTracker to userId
  • Update the README in this regard
  • add a deprecated visitorId mapping to userId to the MatomoTracker with a proper deprecation message (we will keep this until the next major release of the SDK)

@mplackowski
Copy link

Hi,

It would be great to have both parameters in the sdk. I mean the ("cid" and "uid" keys following this documentation: https://developer.matomo.org/api-reference/tracking-api)
In my usecase I need to setup visitorId ("cid" key ) manually after user converts from mobile website to the app.

I'm using branch deeplinks with custom parameters and one of them is the pk_vid from the website.
This way it is possible to track users switching from website to the app in a single visit (assuming that the same tracker is used on website and in the app).

Being able to see user flow as a whole is a great feature, since the mobile website in many cases is the real starting point in the conversion funnel.

@brototyp
Copy link
Member

brototyp commented Jul 3, 2018

@mplackowski I moved this to #259

@brototyp
Copy link
Member

@mattab This got changed and will be part of the next release.

@mattab
Copy link
Member Author

mattab commented Aug 17, 2018

Thank you @brototyp 👍 so good to bring clarity and consistency wherever possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants