Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Visualizations to render API.processedReport to add display properties / report settings #7071

Open
tsteur opened this issue Jan 25, 2015 · 1 comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.

Comments

@tsteur
Copy link
Member

tsteur commented Jan 25, 2015

We will need this for API.getProcessedReport when making more use of AngularJS to render all the reports client side. The Visualization would add several ViewDataTable/Config and ViewDataTable/RequestConfig properties to the report metadata. We will need this in Piwik itself eg to decide whether we have to show footer icons, whether to show a search box, whether to show a filter_limit selector, the default number of rows per datatable, etc. The same is needed for Piwik Mobile see eg matomo-org/matomo-mobile-2#3241 and #3780 to display the reports the same way across apps.

@tsteur tsteur added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Jan 25, 2015
@tsteur tsteur added this to the Piwik 3.0.0 milestone Jan 25, 2015
@mattab mattab added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Feb 19, 2015
@tsteur
Copy link
Member Author

tsteur commented May 4, 2015

This will be needed for #7131 and #4734 . This will allow us to no longer need the $report instance to render a report. Instead we will render based on the API output (in the browser possibly but not necessarily).

Possible problems
We currently define for example filters for API output in configureVieweg https://github.com/piwik/piwik/blob/2.13.0-rc3/plugins/Actions/Reports/Base.php#L47 . This is no good. This should be actually handled in the visualization itself and/or API.getProcessedReport see #7072

@mattab mattab modified the milestones: Short term, 3.0.0 Aug 13, 2015
@innocraft-automation innocraft-automation removed this from the Backlog (Help wanted) milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

3 participants