Change signature of Dimension hooks to allow to change them in the future #8409
Labels
c: Platform
For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
wontfix
If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
In Dimensions we have some "hooks" / methods that are called during tracking: https://github.com/piwik/piwik/blob/2.14.1-rc1/core/Plugin/Dimension/VisitDimension.php#L216-L252
Same applies to
ActionDimension
andConversionDimension
egProblem is that we will never be able to change this signature as it might break plugins. Instead we should pass only one object where one can call
$i->getRequest()
,$i->getVisitor()
, ... It is not as nicely readable etc but it will allow us to change code in the future and provide more parameters.We potentially have similar issues with other classes too, eg
Reports::configureWidgets()
. Those would be ideally changed too. We should do this for 3.0.0 as it will break the APIThe text was updated successfully, but these errors were encountered: