From a8bca21b36914a3505812f8a9cbcd8e2964c7c23 Mon Sep 17 00:00:00 2001 From: Ian Thomas Date: Tue, 28 May 2024 11:52:02 +0100 Subject: [PATCH 1/3] Update binder --- .binder/environment.yml | 7 +++---- .github/workflows/binder-on-pr.yml | 2 +- README.md | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.binder/environment.yml b/.binder/environment.yml index eedf6445..e62858b7 100644 --- a/.binder/environment.yml +++ b/.binder/environment.yml @@ -2,8 +2,7 @@ name: ipympl channels: - conda-forge dependencies: - - yarn - - numpy + - yarn~=3.0 - jupyterlab~=4.0 - - retrolab - - matplotlib-base>=2.2.2 + - ipywidgets>=7.6 + - matplotlib diff --git a/.github/workflows/binder-on-pr.yml b/.github/workflows/binder-on-pr.yml index 6fde8695..6459ef1c 100644 --- a/.github/workflows/binder-on-pr.yml +++ b/.github/workflows/binder-on-pr.yml @@ -19,7 +19,7 @@ jobs: issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo, - body: `[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/${PR_HEAD_USERREPO}/${PR_HEAD_REF}?urlpath=retro/notebooks/docs/examples/full-example.ipynb) :point_left: Launch a binder notebook on branch _${PR_HEAD_USERREPO}/${PR_HEAD_REF}_` + body: `[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/${PR_HEAD_USERREPO}/${PR_HEAD_REF}?urlpath=lab/tree/docs/examples/full-example.ipynb) :point_left: Launch a binder notebook on branch _${PR_HEAD_USERREPO}/${PR_HEAD_REF}_` }) env: PR_HEAD_REF: ${{ github.event.pull_request.head.ref }} diff --git a/README.md b/README.md index eed0002c..465f6c99 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ [![Latest PyPI version](https://img.shields.io/pypi/v/ipympl?logo=pypi)](https://pypi.python.org/pypi/ipympl) [![Latest conda-forge version](https://img.shields.io/conda/vn/conda-forge/ipympl?logo=conda-forge)](https://anaconda.org/conda-forge/ipympl) [![Latest npm version](https://img.shields.io/npm/v/jupyter-matplotlib?logo=npm)](https://www.npmjs.com/package/jupyter-matplotlib) -[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/matplotlib/ipympl/stable?urlpath=retro/notebooks/docs/examples/full-example.ipynb) +[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/matplotlib/ipympl/main?urlpath=lab/tree/docs/examples/full-example.ipynb) [![Gitter](https://img.shields.io/badge/gitter-Join_chat-blue?logo=gitter)](https://gitter.im/jupyter-widgets/Lobby) Leveraging the Jupyter interactive widgets framework, `ipympl` enables the interactive features of matplotlib in the Jupyter notebook and in JupyterLab. From 1023308fc0bfcc2084fa4f2d09e85352995ab535 Mon Sep 17 00:00:00 2001 From: Ian Thomas Date: Tue, 28 May 2024 12:09:47 +0100 Subject: [PATCH 2/3] Fix gha --- .github/workflows/binder-on-pr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/binder-on-pr.yml b/.github/workflows/binder-on-pr.yml index 6459ef1c..493374cb 100644 --- a/.github/workflows/binder-on-pr.yml +++ b/.github/workflows/binder-on-pr.yml @@ -15,7 +15,7 @@ jobs: script: | var PR_HEAD_USERREPO = process.env.PR_HEAD_USERREPO; var PR_HEAD_REF = process.env.PR_HEAD_REF; - github.issues.createComment({ + github.rest.issues.createComment({ issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo, From 61143bf4604166f965eefc02b7d045821fa417a5 Mon Sep 17 00:00:00 2001 From: Ian Thomas Date: Tue, 28 May 2024 13:02:56 +0100 Subject: [PATCH 3/3] Try using notebook --- .binder/environment.yml | 1 + .github/workflows/binder-on-pr.yml | 2 +- README.md | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.binder/environment.yml b/.binder/environment.yml index e62858b7..f0dcc096 100644 --- a/.binder/environment.yml +++ b/.binder/environment.yml @@ -6,3 +6,4 @@ dependencies: - jupyterlab~=4.0 - ipywidgets>=7.6 - matplotlib + - notebook>=7 diff --git a/.github/workflows/binder-on-pr.yml b/.github/workflows/binder-on-pr.yml index 493374cb..8fc5b8f8 100644 --- a/.github/workflows/binder-on-pr.yml +++ b/.github/workflows/binder-on-pr.yml @@ -19,7 +19,7 @@ jobs: issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo, - body: `[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/${PR_HEAD_USERREPO}/${PR_HEAD_REF}?urlpath=lab/tree/docs/examples/full-example.ipynb) :point_left: Launch a binder notebook on branch _${PR_HEAD_USERREPO}/${PR_HEAD_REF}_` + body: `[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/${PR_HEAD_USERREPO}/${PR_HEAD_REF}?urlpath=notebooks/docs/examples/full-example.ipynb) :point_left: Launch a binder notebook on branch _${PR_HEAD_USERREPO}/${PR_HEAD_REF}_` }) env: PR_HEAD_REF: ${{ github.event.pull_request.head.ref }} diff --git a/README.md b/README.md index 465f6c99..1a3cf8c9 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ [![Latest PyPI version](https://img.shields.io/pypi/v/ipympl?logo=pypi)](https://pypi.python.org/pypi/ipympl) [![Latest conda-forge version](https://img.shields.io/conda/vn/conda-forge/ipympl?logo=conda-forge)](https://anaconda.org/conda-forge/ipympl) [![Latest npm version](https://img.shields.io/npm/v/jupyter-matplotlib?logo=npm)](https://www.npmjs.com/package/jupyter-matplotlib) -[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/matplotlib/ipympl/main?urlpath=lab/tree/docs/examples/full-example.ipynb) +[![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/matplotlib/ipympl/main?urlpath=notebooks/docs/examples/full-example.ipynb) [![Gitter](https://img.shields.io/badge/gitter-Join_chat-blue?logo=gitter)](https://gitter.im/jupyter-widgets/Lobby) Leveraging the Jupyter interactive widgets framework, `ipympl` enables the interactive features of matplotlib in the Jupyter notebook and in JupyterLab.