Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid server name in .well-known reports FederationOK: true #106

Open
auscompgeek opened this issue Jul 13, 2020 · 5 comments
Open

Invalid server name in .well-known reports FederationOK: true #106

auscompgeek opened this issue Jul 13, 2020 · 5 comments

Comments

@auscompgeek
Copy link

For example when https:// is in m.server, an Error will be correctly reported "Invalid server name 'https://...' in .well-known result", but FederationOK will be true.

@richvdh
Copy link
Member

richvdh commented Jul 13, 2020

I believe that's correct behaviour. A malformed .well-known file is ignored by the protocol.

https://matrix.org/docs/spec/server_server/r0.1.3#resolving-server-names:

The schema of the /.well-known request is later in this section. If the response is invalid (bad JSON, missing properties, non-200 response, etc), skip to step 4.

@richvdh
Copy link
Member

richvdh commented Jul 13, 2020

hrm, I suppose "the m.server property is there, but its content is invalid" isn't really covered by that - and it's probably also not what synapse does.

@auscompgeek
Copy link
Author

Hmm, even if the well-known should be ignored, the rest of the report is empty too.

@aaronraimist
Copy link

This also causes the GUI to not show any errors even if matrix-federation-tester's json report shows Invalid server name.

@richvdh
Copy link
Member

richvdh commented Sep 28, 2022

I wonder if this is still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants