Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GetVersion in a goroutine #84

Open
babolivier opened this issue May 1, 2019 · 0 comments
Open

Run GetVersion in a goroutine #84

babolivier opened this issue May 1, 2019 · 0 comments

Comments

@babolivier
Copy link
Contributor

When fetching the server version, if the endpoint times out, it means that we have to wait an extra 30s before getting our results, meaning that if everything times out we have to wait for 40s. Doing so is not necessary for tests, thus the request can be run in parallel with the connection reports, and save 10s.

Bonus points if we standardise the timeout by creating the gomatrixserverlib client using NewClientWithTimeout instead of NewClient so that it takes up to as much time as other requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant