-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS certificate chain checking #90
Comments
I don't quite follow what you're asking for. Are you looking for different wording to replace "certificate signed by unknown authority", or for the tester to somehow distinguish a certificate which is not signed by a known authority from one which is signed by an authority which is known, but not known to us? |
The latter. Cases such as using |
Indeed they aren't (which is why that case is specifically called out in https://github.com/matrix-org/synapse/blob/master/INSTALL.md#tls-certificates), but given the problem is that we don't know about the intermediate CA certs, that doesn't answer the question of how we can tell if the problem is a missing intermediate cert, or a cert signed by an unrecognised CA. But apparently there is an X.509 extension which allows certs to specify the URL that the CA cert can be downloaded from, so in theory we could download the CA certs and see if we can form a complete chain. |
A "certificate signed by unknown authority" error isn't very useful when the cert is valid, but the chain is incomplete. It would be nice if the tester tested the cert for such cases and provided exact errors (maybe even including instructions and a cert file for fixing it like https://whatsmychaincert.com/)
The text was updated successfully, but these errors were encountered: