Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase feed.pollTimeoutSeconds from 10s to 30s #483

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

Half-Shot
Copy link
Contributor

10s seems too low in practice for things like GitHub, and it does seem to be doing more harm than good.

@Half-Shot Half-Shot requested a review from a team as a code owner September 12, 2022 12:41
@tadzik
Copy link
Contributor

tadzik commented Sep 12, 2022

We're testing this internally first to see if it has the desired effect.

@HarHarLinks
Copy link
Contributor

I've bumped my setting to 20s based on discussion in the hookshot matrix room and had no more feed timeout issues for 5 days when there used to be multiple per day.

@Half-Shot
Copy link
Contributor Author

Alrighty, in that case I think this is probably fine.

@Half-Shot Half-Shot merged commit 93e2dbe into main Nov 25, 2022
@Half-Shot Half-Shot deleted the hs/increase-default-timeout branch November 25, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants