Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden against unauthorized changes to room state #565

Merged
merged 8 commits into from
Nov 22, 2022
Merged

Harden against unauthorized changes to room state #565

merged 8 commits into from
Nov 22, 2022

Conversation

AndrewFerr
Copy link
Member

If an unauthorized change to connection-related room state is detected, deny the new connection settings & attempt to revert the state change.

Also catch an otherwise-uncaught error on authentication failure.

@AndrewFerr
Harden against unauthorized changes to room state
32dc75f 
If an unauthorized change to connection-related room state is detected,
deny the new connection settings & attempt to revert the state change.

Also catch an otherwise-uncaught error on authentication failure.
@AndrewFerr
any->unknown for some StateEvent content types
7a606c0
@AndrewFerr AndrewFerr added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. S-Major Severely degrades major functionality or product features, with no satisfactory workaround javascript Pull requests that update Javascript code labels Nov 3, 2022
@AndrewFerr AndrewFerr requested a review from a team as a code owner November 3, 2022 05:01
@AndrewFerr AndrewFerr self-assigned this Nov 3, 2022
jaller94
jaller94 suggested changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm asking you to write a back-off counter to avoid infinite or near-infinite loops.

src/ConnectionManager.ts Outdated Show resolved Hide resolved
src/ConnectionManager.ts Outdated Show resolved Hide resolved
@AndrewFerr AndrewFerr requested a review from jaller94 November 3, 2022 12:52
@AndrewFerr
Copy link
Member Author

@jaller94 If the latest changes are fine by you, I'll merge this today.

Half-Shot
Half-Shot requested changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I failed to submit this review.

src/Bridge.ts Outdated Show resolved Hide resolved
src/ConnectionManager.ts Outdated Show resolved Hide resolved
src/ConnectionManager.ts Outdated Show resolved Hide resolved
@AndrewFerr AndrewFerr requested a review from Half-Shot November 7, 2022 14:56
Half-Shot
Half-Shot requested changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern, otherwise good!

@AndrewFerr AndrewFerr requested a review from Half-Shot November 22, 2022 15:29
@AndrewFerr AndrewFerr merged commit 16c052e into main Nov 22, 2022
@AndrewFerr AndrewFerr deleted the af/soft-error-on-permission-denial branch November 22, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

@jaller94 jaller94 Awaiting requested review from jaller94

Assignees

@AndrewFerr AndrewFerr

Labels
javascript Pull requests that update Javascript code S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewFerr @Half-Shot @jaller94