Allow GitLab connections without hook permissions #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warn instead of fail when connecting a GitLab project that Hookshot cannot provision a webhook for.
|
Fixes #545 |
AndrewFerr
added
T-Enhancement
Half-Shot
reviewed
Nov 7, 2022
Half-Shot
requested changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn instead of fail when connecting a GitLab project that Hookshot cannot provision a webhook for.
This also updates documentation to explain that "Maintainer" or higher permissions are required on a GitLab project for Hookshot to be able to add a webhook to it.
The warning appears for both
hookshot gitlab project <url>and the widget: