Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the account data event m.direct after accepting an invite #1676

Closed
alfogrillo opened this issue Mar 16, 2023 · 1 comment · Fixed by #1775
Closed

Update the account data event m.direct after accepting an invite #1676

alfogrillo opened this issue Mar 16, 2023 · 1 comment · Fixed by #1775
Assignees
Labels
enhancement New feature or request Z-ElementX-Alpha Required for ElementX Alpha (Q2 2022)

Comments

@alfogrillo
Copy link
Contributor

alfogrillo commented Mar 16, 2023

The matrix protocol specifies that clients (both the creator of a DM room and joiners) are in charge to flag the room as DM chat.
This is being done in two places but using the same mechanism: account_data (event m.direct).
On rooms' creation we already update the account data automatically (done in Rust).

This issue is about updating m.direct when accepting an invitation for a DM chat.

Behaviour
When accepting an invitation the user looks inside his invite (an event of type m.room.member) and check under the path content.is_direct if the flag is set to true. If yes, he has to register the room id in his own account_data inside m.direct just after he joins the room.

@alfogrillo alfogrillo added enhancement New feature or request Z-ElementX-Alpha Required for ElementX Alpha (Q2 2022) labels Mar 16, 2023
@alfogrillo alfogrillo changed the title Update the account data event m.direct when receiving a new invite for a dm chat Update the account data event m.direct after accepting an invite Mar 20, 2023
@jplatte
Copy link
Collaborator

jplatte commented Mar 20, 2023

This should probably be done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Z-ElementX-Alpha Required for ElementX Alpha (Q2 2022)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants