Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/room/${roomID}/messages requires "from" parameter, but should it? #1892

Closed
Half-Shot opened this issue Feb 18, 2019 · 3 comments · Fixed by #3567
Closed

/room/${roomID}/messages requires "from" parameter, but should it? #1892

Half-Shot opened this issue Feb 18, 2019 · 3 comments · Fixed by #3567
Labels
client-server Client-Server API improvement A suggestion for a relatively simple improvement to the protocol

Comments

@Half-Shot
Copy link
Contributor

https://matrix.org/docs/spec/client_server/r0.4.0.html#get-matrix-client-r0-rooms-roomid-messages

Synapse doesn't require the from parameter and functions well enough without it. I believe omitting from will get you the last N events in the room. This is useful for bridges/bots who wish to get messages they may have missed after being invited, who otherwise may have no existing token to use for from.

Can we drop this requirement and spec that a lack of from will pull the last N messages from the room?

@Half-Shot Half-Shot added improvement A suggestion for a relatively simple improvement to the protocol client-server Client-Server API labels Feb 18, 2019
@timokoesters
Copy link

Currently chat backups don't work on Conduit because of this bug. Either chat backups should set the from value or this should be changed in the spec soon.

@clokep
Copy link
Member

clokep commented Dec 21, 2021

MSC3567 makes it optional.

@turt2live
Copy link
Member

Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API improvement A suggestion for a relatively simple improvement to the protocol
Projects
None yet
4 participants