Fix missed rst->md numbered list syntax for m.room.server_acl
#3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhoreg
approved these changes
Jan 27, 2022
turt2live
requested changes
Jan 27, 2022
Oh, why do you prefer real numbers? I find the advantage of this is that items can be added to the list without having to reflow the numbers. |
|
It's so that the raw markdown can theoretically be used as a reference without the HTML rendering, and to make review easier down the line when we say "Rule 4 is changed" |
|
Thank you, I hadn't considered those points. That sounds like reason enough to change it. |
turt2live
approved these changes
Jan 28, 2022
|
oh, it has a changelog and I'm blind. |
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some left-over RST syntax which was causing a numbered list to have broken formatting:
This PR applies the equivalent markdown syntax.
Preview: https://pr3681--matrix-org-previews.netlify.app