Add HTML ids for object definitions in the formatted specification #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the callers to resolve-additional-types already call resolve-allof (or if not, they should), so this is redundant.
I want to add more params to this, so first make it take a dict.
... which means we can use the result from resolve-additional-types directly.
This means that it will generate an anchor for each type, whihc will then be passed into render-object-table and used as an `id` for the table.
turt2live
approved these changes
Jul 19, 2022
|
I'm merging this out of desperation for local git problems. |
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to hyperlink between the various object definitions in the spec. By way of a start, let's give each of the generated
<table>s anid.Suggest reviewing this commit-by-commit. It's not terribly complicated, but the total diff isn't that easy to follow.
Also, for easy reference, the diff in the generated spec: spec.diff.txt
Preview: https://pr1174--matrix-spec-previews.netlify.app