Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling room mentions (@room pings) #1399

Closed
Mikaela opened this issue Jan 9, 2023 · 4 comments
Closed

Allow disabling room mentions (@room pings) #1399

Mikaela opened this issue Jan 9, 2023 · 4 comments
Labels
improvement An idea/future MSC for the spec

Comments

@Mikaela
Copy link

Mikaela commented Jan 9, 2023

Suggestion

If I understand correctly, currently the only way to opt-out of @room mentions is to disable all notifications for a room which isn't desirable. It's possible for a room to mention everone more often than fits individual preferences, so I think having an option to disable the notifications per-room would be desirable.

I asked about this at #1074 (comment) where I learned that @room has its own push rule and understand that the issue of replies to @room triggering notifications is addressed by matrix-org/matrix-spec-proposals#3664. I also asked in spec room and was informed that in Matrix it's preferable to open a duplicate rather than asking whether an issue exists.

Other platforms with the feature of pinging everyone, such as Discord has the option to disable @everyone notifications per-room and I think Telegram also has option to disable notifications when moderator pinning a message selects "notify everyone".

@Mikaela Mikaela added the improvement An idea/future MSC for the spec label Jan 9, 2023
@Mikaela
Copy link
Author

Mikaela commented Jan 9, 2023

I was able to locate this issue at element-hq/element-web#12769 & element-hq/element-meta#1631, but as I am experiencing this in Nheko and FluffyChat too, I believe this to be a Spec issue rather than one with Element-Web.

@zecakeh
Copy link
Contributor

zecakeh commented Jan 9, 2023

It is doable with the spec, by adding a push rule like this in the override rules:

{
  "actions": [
    "dont_notify"
  ],
  "conditions": [
    {
      "key": "room_id",
      "kind": "event_match",
      "pattern": "!room_id:server.org"
    },
    {
      "kind": "event_match",
      "key": "content.body",
      "pattern": "@room"
    }               
  ]
}

The only catch is that it would prevent the default .m.rule.contains_display_name rule from triggering if the event content looks like this: @room Alice is in Wonderland (and the user's display name is Alice). But I doubt that's a behavior that someone would be counting on anyway.

@richvdh
Copy link
Member

richvdh commented Feb 1, 2023

As @zecakeh says, I think this is something you can do with pushrules today, so this isn't a spec issue.

(There are plenty of things you can't do with pushrules, and I continue to believe the whole system needs replacing, but this isn't one of them).

Also note that dont_notify is a no-op (#643)

@richvdh richvdh closed this as completed Feb 1, 2023
@richvdh
Copy link
Member

richvdh commented Feb 1, 2023

If I understand correctly, currently the only way to opt-out of @room mentions is to disable all notifications for a room which isn't desirable.

Also note that if you want to opt out of @room mentions altogether, you can do so by disabling the .m.rule.roomnotif pushrule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An idea/future MSC for the spec
Projects
None yet
Development

No branches or pull requests

3 participants