Spec annotations #1475
Merged
Spec annotations #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/spec_reactions
branch
from
b68fd0c to
c31a073
Compare
richvdh
force-pushed
the
rav/spec_reactions
branch
from
c31a073 to
3fea1a6
Compare
richvdh
commented
Mar 29, 2023
Comment on lines
+81
to
+82
| Attempts to send such an annotation should be rejected with a 400 error and an | ||
| error code of `M_DUPLICATE_ANNOTATION`. |
There was a problem hiding this comment.
wonder if I should add something about this to the docs on /send
There was a problem hiding this comment.
Yes, I think so. That endpoint seems to need more documentation about errors in general, but starting with this would be a good step at least.
uhoreg
approved these changes
Apr 18, 2023
Comment on lines
+81
to
+82
| Attempts to send such an annotation should be rejected with a 400 error and an | ||
| error code of `M_DUPLICATE_ANNOTATION`. |
There was a problem hiding this comment.
Yes, I think so. That endpoint seems to need more documentation about errors in general, but starting with this would be a good step at least.
Co-authored-by: Hubert Chathi <[email protected]>
This was referenced Apr 26, 2023
clokep
pushed a commit
to clokep/matrix-spec
that referenced
this pull request
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec for MSC2677
Includes #1476Preview: https://pr1475--matrix-spec-previews.netlify.app