Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sas: clarify ECDH process in step 12 #1720

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

sumnerevans
Copy link
Contributor

@sumnerevans sumnerevans commented Jan 30, 2024


name: sas: clarify ECDH process in step 12
about: As written, the spec is not clear what Bob's device is supposed to do as that device does not have Alice's device's private key.
title: ''
labels: ''
assignees: ''


As written, the spec is not clear what Bob's device is supposed to do as that device does not have Alice's device's private key.

Signed-off-by: Sumner Evans [email protected]

Pull Request Checklist

Preview: https://pr1720--matrix-spec-previews.netlify.app

@sumnerevans sumnerevans requested a review from a team as a code owner January 30, 2024 06:43
As written, the spec is not clear what Bob's device is supposed to do as
that device does not have Alice's device's private key.

Signed-off-by: Sumner Evans <[email protected]>
Copy link
Member

@dkasak dkasak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the tiny stylistic suggestion, this is correct and should be ready to merge.

@anoadragon453 anoadragon453 merged commit 9a1f0ad into matrix-org:main Feb 26, 2024
12 checks passed
@sumnerevans sumnerevans deleted the clarify-sas-ecdh branch February 26, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants