From e9d3f84d2eb07f52c4bf02ba97020bfe625335de Mon Sep 17 00:00:00 2001 From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Date: Tue, 19 Dec 2023 14:58:58 +0000 Subject: [PATCH 1/4] Wording tweak in CONTRIBUTING.rst It's not just API changes that need changelogs. --- CONTRIBUTING.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 46c6c560a..2c2aef4f7 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -72,7 +72,7 @@ ask. Adding to the changelog ~~~~~~~~~~~~~~~~~~~~~~~ -All API specifications require a changelog entry. Adding to the changelog can only +All changes to the specificatios require a changelog entry. Adding to the changelog can only be done after you've opened your pull request, so be sure to do that first. The changelog is managed by `Towncrier `_ in the From 49c5c5816e25814d8139ce31934e2fa04476252b Mon Sep 17 00:00:00 2001 From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Date: Tue, 19 Dec 2023 14:59:31 +0000 Subject: [PATCH 2/4] Update CONTRIBUTING.rst --- CONTRIBUTING.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 2c2aef4f7..dad7cd9c9 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -72,7 +72,7 @@ ask. Adding to the changelog ~~~~~~~~~~~~~~~~~~~~~~~ -All changes to the specificatios require a changelog entry. Adding to the changelog can only +All changes to the specification require a changelog entry. Adding to the changelog can only be done after you've opened your pull request, so be sure to do that first. The changelog is managed by `Towncrier `_ in the From 361199cb64f82538fdeadb167340130eb559fd89 Mon Sep 17 00:00:00 2001 From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Date: Thu, 21 Dec 2023 11:38:56 +0000 Subject: [PATCH 3/4] Update CONTRIBUTING.rst --- CONTRIBUTING.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index dad7cd9c9..93763a29e 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -72,7 +72,7 @@ ask. Adding to the changelog ~~~~~~~~~~~~~~~~~~~~~~~ -All changes to the specification require a changelog entry. Adding to the changelog can only +All changes to the contents of this repository require a changelog entry. Adding to the changelog can only be done after you've opened your pull request, so be sure to do that first. The changelog is managed by `Towncrier `_ in the From c2ed88d94dcdc38ba4543c3ef878def32a0c7533 Mon Sep 17 00:00:00 2001 From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Date: Thu, 21 Dec 2023 11:39:55 +0000 Subject: [PATCH 4/4] Create 1697.clarification --- changelogs/internal/newsfragments/1697.clarification | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelogs/internal/newsfragments/1697.clarification diff --git a/changelogs/internal/newsfragments/1697.clarification b/changelogs/internal/newsfragments/1697.clarification new file mode 100644 index 000000000..d238b2e9f --- /dev/null +++ b/changelogs/internal/newsfragments/1697.clarification @@ -0,0 +1 @@ +Minor clarifications to the contributing guide.