Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: MessageIsMedia does not check m.new_content #481

Closed
eyJhb opened this issue May 11, 2023 · 0 comments · Fixed by #516
Closed

BUG: MessageIsMedia does not check m.new_content #481

eyJhb opened this issue May 11, 2023 · 0 comments · Fixed by #516
Labels
T-Defect Something isn't working, this is a bug

Comments

@eyJhb
Copy link

eyJhb commented May 11, 2023

When blocking messages there is media, it is possible to bypass if editing the message.
This can be done by sending a new m.room.message with m.new_content being a image type instead (m.image).
This will get posted, without mjolnir reacting to it, and blocking it :)

It seems like MessageIsMedia should recurse into messages, to check for such things.

Hopefully this is the correct way to report it!

EDIT: should clarify, this bypasses everything in the current checker, unless the checker recurses into the message.

@eyJhb eyJhb changed the title BUG: MessageIsMediadoes not check m.new_content BUG: MessageIsMedia does not check m.new_content May 11, 2023
@H-Shay H-Shay added the T-Defect Something isn't working, this is a bug label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working, this is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants