-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There are no tests to ensure that floats fail #22
Comments
looks like #17 fixes this |
Seems like this would be nice, but I don't think we can do it -- see matrix-org/synapse#7381 and related issues. |
I think we should make it turn-on-and-off-able: add an option to reject floats. |
This is still an issue, I was looking for a method by which synapse ensures that ints do not exceed their maximum value, and i found none. #17 is closed, I'll look into making a new PR. |
Additionally: it's not just that the tests fail, but we don't reject floats whatsoever: >>> canonicaljson.encode_canonical_json({"x": 1.23})
b'{"x":1.23}' |
We could add some kind of opt-in |
I wonder if we should just plan to break such old Synapse releases. We could deprecate the |
As per spec:
There isn't any code that checks for floats, either.
The text was updated successfully, but these errors were encountered: