Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emails migration docs #392

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Fix emails migration docs #392

merged 3 commits into from
Sep 14, 2021

Conversation

babolivier
Copy link
Contributor

Turns out I misread arguments and config_file is not a flag

@babolivier
Fix emails migration docs
7b3f493 
Turns out I misread arguments and config_file is not a flag
@babolivier
Changelog
0dfaa80
@babolivier babolivier requested a review from a team September 10, 2021 09:58
anoadragon453
anoadragon453 approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code, I could see how that would be confusing!

changelog.d/392.doc Outdated Show resolved Hide resolved
@babolivier @anoadragon453
Update changelog.d/392.doc
5df732e 
Co-authored-by: Andrew Morgan <[email protected]>
@babolivier babolivier merged commit 7a1fe9f into main Sep 14, 2021
@babolivier babolivier deleted the babolivier/migration_docs branch September 14, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reivilibre reivilibre reivilibre left review comments

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babolivier @anoadragon453 @reivilibre