Fix KeyError on unbinding addresses #397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo in the
removeBinding
function which seems to be causing unbindings to fail in Sydent.The function
normalise_address
expects the medium to be passed as the second argument:sydent/sydent/util/stringutils.py
Lines 131 to 135 in d6db3b1
Which in most cases would be "email". The code had
threepid["email"]
instead.Introduced in #374.