Remove invalid await in replication code #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
approved these changes
Sep 14, 2021
|
Err, yes. Probably a poor choice of words. It will raise an exception without fail. |
anoadragon453
changed the title
|
Is this deployed? I can still see those errors in Sentry coming through today. |
|
I don't think it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extra
awaitended up in #364.This may prevent successful reporting of peer replication results, causing replication payloads to increase over time as the same associations are replicated over and over.
Logs may have many instances of
Error pushing updates to <hostname>:<port>as well.Discovered via Sentry: https://sentry.matrix.org/sentry/sydent/issues/230767/?query=is%3Aunresolved.