GET from MsisdnValidateCodeServlet broken?

[DMRobertson]

Inside render_GET we call get_args and destructure the result to a 2-tuple:

sydent/sydent/http/servlets/msisdnservlet.py

Line 131 in 567eb1a

err, args = get_args(request, ("token", "sid", "client_secret"))

get_args returns a dictionary, and has done since 687d774. The destructing will fail unless the dictionary contains two keys.

sydent/sydent/http/servlets/__init__.py

Lines 46 to 48 in a6fff7b

	request: Request, args: Iterable[str], required: bool = True
	) -> Dict[str, Any]:
	"""

Everywhere else, we use args = get_args with no destructuring. I guess we missed this servelet in that change and either nobody noticed or the endpoint is unused.

[DMRobertson]

https://sentry.matrix.org/sentry/sydent/issues/16284/ spotted by @clokep

[clokep]

sentry.matrix.org/sentry/sydent/issues/16284 spotted by @clokep

I think this might actually be unrelated. I would have expected "not enough values to unpack" while that error is "too many values to unpack".

[DMRobertson]

I would have expected "not enough values to unpack" while that error is "too many values to unpack".

A dictionary with N keys will happily desugar into an N-tuple:

>>> d = {"a": 1, "b": 2, "c": 3}
>>> x, y, z = d
>>> x, y, z
('a', 'b', 'c')

So if get_args returned 3 or more args, we'd see "too many values to unpack".