Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught EmailAddressExceptions #451

Closed
DMRobertson opened this issue Oct 29, 2021 · 1 comment · Fixed by #464
Closed

Uncaught EmailAddressExceptions #451

DMRobertson opened this issue Oct 29, 2021 · 1 comment · Fixed by #464
Labels
T-Defect

Comments

@DMRobertson
Copy link
Contributor

https://sentry.matrix.org/sentry/sydent/issues/196870/

sendEmail might raise EmailAddressException or EmailSendError. The former is almost certainly indicative of a bad request. We should return HTTP 400 if so. I suspect that we instead return 500 internal server error.

https://sentry.matrix.org/sentry/sydent/issues/196870/
@DMRobertson
Copy link
Contributor Author

Note that this is raised if we fail to parse the from address in Sydent config. I'll ensure that raises a different exception so that we end up returning 500 for that one.

@DMRobertson DMRobertson mentioned this issue Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Catch EmailAddressExceptions and return 400 matrix-org/sydent
1 participant
@DMRobertson