Include a version string in sentry reports #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following is the sum total of all the testing I've done: $ python
Python 3.9.7 (default, Aug 30 2021, 00:00:00)
[GCC 11.2.1 20210728 (Red Hat 11.2.1-1)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import sydent.util.versionstring
>>> sydent.util.versionstring.get_version_string()
'[email protected] (b=dmr/version-in-sentry,05e1fa8,dirty)' |
DMRobertson
force-pushed
the
dmr/version-in-sentry
branch
from
05e1fa8 to
933067c
Compare
erikjohnston
approved these changes
Nov 1, 2021
anoadragon453
approved these changes
Nov 1, 2021
Comment on lines
+11
to
+13
| """Calculate a git-aware version string for sydent. | ||
|
|
||
| Implementation nicked from Synapse. |
There was a problem hiding this comment.
I think it's worth writing a bit more here as to what form the version string will actually take (given what information can be found).
| @@ -0,0 +1 @@ | |||
| Include Sydent's version number when reporting to Sentry. | |||
There was a problem hiding this comment.
Suggested change
| Include Sydent's version number when reporting to Sentry. | |
| Include Sydent's version number (and git commit hash if available) when reporting to Sentry. |
|
Will open a second PR with changes for these @anoadragon453 |
|
With a specific commit hash checked out, b=HEAD wasn't so useful. But it's good enough.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.