Catch failures to decode JSON in /register #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like #456, but for another error case. If the remote homeserver fails to give us sensible response, that's not a problem in our application. We can continue to serve everyone else. We should tell the requester what happened and log a warning, but not an error to Sentry. Most of the examples I saw in Sentry were 404 responses serving up a generic "page not found" body.
DMRobertson
force-pushed
the
dmr/catch-json-decode-error
branch
from
9c03475 to
f1ae64f
Compare
DMRobertson
pushed a commit
that referenced
this pull request
Nov 11, 2021
Addresses https://sentry.matrix.org/sentry/sydent/issues/235004/?query=is%3Aunresolved%20event.timestamp%3A%3E%3D2021-11-03T10%3A00%3A00 That issue is rare---it's only occurred twice---but since it's so close to #456 I thought I may as well throw it in too. (I suppose this might encounter the problem in #463 as well, though we haven't seen it in Sentry. I think unbinds are just much less used that registers. I don't know if there's a better way to handle all this duplication though?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #456, but for another error case.
If the remote homeserver fails to give us sensible response, that's not
a problem in our application. We can continue to serve everyone else. We
should tell the requester what happened and log a warning, but not an
error to Sentry.
Most of the examples I saw in Sentry were 404 responses serving up a
generic "page not found" body.