Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in type hints for pynacl #478

Closed
DMRobertson opened this issue Dec 24, 2021 · 2 comments · Fixed by #484
Closed

Pull in type hints for pynacl #478

DMRobertson opened this issue Dec 24, 2021 · 2 comments · Fixed by #484

Comments

@DMRobertson
Copy link
Contributor

In my spare time (i.e. not paid Element time) I've been working to add type annotations to pynacl, see pyca/pynacl#660. This is almost done, and the maintainer is keen to include them in a new minor release, "in the next few days/weeks".

Once there's a release, we should remove pynacl from the list of imports we ignore in Sydent's mypy config. Then we should fixup any complaints. The same also holds true for signedjson and synapse.

From a quick glance, there seem to be two complaints:

  • we're adding version and alg attributes to pynacl SigningKey instances (both in Sydent and signedjson)
  • we're creating a SigningKey with a str rather than a bytes (missed in 2->3 conversion?)
@H-Shay
Copy link
Contributor

H-Shay commented Jan 12, 2022

Looks like pynacl 1.5.0 is out, so we can go ahead with this.

@DMRobertson
Copy link
Contributor Author

Many thanks to Olivier for doing this in #484.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants