Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aggressive logging to casefolddb.py script for debugging purposes #486

Merged
merged 9 commits into from
Jan 26, 2022
Merged

Add aggressive logging to casefolddb.py script for debugging purposes #486

merged 9 commits into from
Jan 26, 2022

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Jan 21, 2022

As the title states. Not sure if this will be permanent? But needed for running the script next time

@H-Shay H-Shay requested a review from a team as a code owner January 21, 2022 20:04
@H-Shay H-Shay marked this pull request as draft January 21, 2022 20:04
@H-Shay H-Shay removed the request for review from a team January 24, 2022 18:45
reivilibre
reivilibre approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No nice f-string syntax whilst logging — sorry (this one catches me out too).
Some of the log lines might be better as debug, some as warning, so I've proposed changing those.

Looks good to me though — thanks for doing this!

scripts/casefold_db.py Outdated Show resolved Hide resolved
scripts/casefold_db.py Outdated Show resolved Hide resolved
scripts/casefold_db.py Outdated Show resolved Hide resolved
@H-Shay H-Shay marked this pull request as ready for review January 26, 2022 17:03
@H-Shay H-Shay merged commit c6c8b99 into main Jan 26, 2022
@H-Shay H-Shay deleted the shay/add_logging branch January 26, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reivilibre reivilibre reivilibre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@H-Shay @reivilibre