Don't log succesful SMS sends twice #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2022 14:11
| @@ -161,11 +161,3 @@ async def sendTextSMS( | |||
| request_id, | |||
| resp.code, | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Not explicitly part of this PR, but should the above logger.error lines be accompanied with a return?
There was a problem hiding this comment.
Yes. What the dickens is happening here?
There was a problem hiding this comment.
Tempted as I am to rewrite the whole thing, I'll be a good boy: stick in the return and call it a day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.