-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try building docker images #492
Conversation
5127eb5
to
641ec6d
Compare
641ec6d
to
80e9595
Compare
d6dfe94
to
0660f88
Compare
0660f88
to
e973fe8
Compare
See matrix-org/backend-meta#2 for the workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
For some reason synapse calls the secrets DOCKERHUB_USERNAME
and DOCKERHUB_TOKEN
, without the underscore. I believe Synapse is the odd one out, since the secrets defined at the organization level include the extra underscore.
I'll change the workflow to include the extra underscore, to avoid this potential footgun. And I can later change Synapse to use the org-level secret. |
This failed when I tested it with my account, but I think that's because the access token expired. I'm going to revert to 8f7b773, commit this, and then take it from there. We can refine/fixup later. |
This worked in this CI run to publish this.