Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try building docker images #492

Merged
merged 10 commits into from
Feb 14, 2022
Merged

Try building docker images #492

merged 10 commits into from
Feb 14, 2022

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Feb 8, 2022

This worked in this CI run to publish this.

@DMRobertson
Copy link
Contributor Author

See matrix-org/backend-meta#2 for the workflow

@DMRobertson DMRobertson marked this pull request as ready for review February 11, 2022 18:29
@DMRobertson DMRobertson requested a review from a team as a code owner February 11, 2022 18:29
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

For some reason synapse calls the secrets DOCKERHUB_USERNAME and DOCKERHUB_TOKEN, without the underscore. I believe Synapse is the odd one out, since the secrets defined at the organization level include the extra underscore.

@DMRobertson
Copy link
Contributor Author

For some reason synapse calls the secrets DOCKERHUB_USERNAME and DOCKERHUB_TOKEN, without the underscore. I believe Synapse is the odd one out, since the secrets defined at the organization level include the extra underscore.

I'll change the workflow to include the extra underscore, to avoid this potential footgun. And I can later change Synapse to use the org-level secret.

@DMRobertson DMRobertson marked this pull request as draft February 14, 2022 12:09
@DMRobertson
Copy link
Contributor Author

This failed when I tested it with my account, but I think that's because the access token expired. I'm going to revert to 8f7b773, commit this, and then take it from there. We can refine/fixup later.

Revert "...and fix typo"

This reverts commit 726fd0b.

Revert "Correct branch name"

This reverts commit 18d4ed7.

Revert "Test on my dockerhub acct after workflow changes"

This reverts commit 9bd0758.
@DMRobertson DMRobertson marked this pull request as ready for review February 14, 2022 18:18
@DMRobertson DMRobertson merged commit 49fef3a into main Feb 14, 2022
@DMRobertson DMRobertson deleted the dmr/docker-poetry branch February 14, 2022 18:19
@DMRobertson DMRobertson linked an issue Feb 14, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build docker image in CI and publish to dockerhub on releases
2 participants