Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump twisted from 21.7.0 to 22.1.0 #495

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 11, 2022

Bumps twisted from 21.7.0 to 22.1.0.

Release notes

Sourced from twisted's releases.

Twisted 22.1.0 (2022-02-03)

Features

  • Python 3.10 is now a supported platform (#10224)
  • Type annotations have been added to the twisted.python.fakepwd module. (#10287)

Bugfixes

  • twisted.internet.defer.inlineCallbacks has an improved type annotation, to avoid typing errors when it is used on a function which returns a non-None result. (#10231)
  • twisted.internet.base.DelayedCall.__repr__ and twisted.internet.task.LoopingCall.__repr__ had the changes from #10155 reverted to accept non-function callables. (#10235)
  • Revert the removal of .whl building that was done as part of #10177. (#10236)
  • The type annotation of the host parameter to twisted.internet.interfaces.IReactorTCP.connectTCP has been corrected from bytes to str. (#10251)
  • Deprecated twisted.python.threading.ThreadPool.currentThread() in favor of threading.current_thread(). Switched twisted.python.threading.ThreadPool.currentThread() and twisted.python.threadable.getThreadID() to use `threading.current_thread()to avoid the deprecation warnings introduced forthreading.currentThread()`` in Python 3.10. (#10273)

Improved Documentation

  • twisted.internet.utils.runWithWarningsSupressed behavior of waiting on deferreds has been documented. (#10238)
  • Sync API docs templates with pydoctor 21.9.0 release, using new theming capabilities. (#10267)

Misc

Conch

Features


- twisted.conch.ssh now supports SSH extension negotiation (RFC 8308). ([#10266](https://github.com/twisted/twisted/issues/10266))

Bugfixes

  • twisted.conch now uses constant-time comparisons for MACs. (#8199)
  • twisted.conch.ssh.filetransfer.FileTransferServer will now return an ENOENT error status if an SFTP client tries to close an unrecognized file handle. (#10293)
  • SSHTransportBase.ssh_KEXINIT now uses the remote peer preferred MAC list for negotiation. In previous versions it was only using the local preferred MAC list. (#10241)

... (truncated)

Changelog

Sourced from twisted's changelog.

Twisted 22.1.0 (2022-02-03)

Features

  • Python 3.10 is now a supported platform (#10224)
  • Type annotations have been added to the twisted.python.fakepwd module. (#10287)

Bugfixes

  • twisted.internet.defer.inlineCallbacks has an improved type annotation, to avoid typing errors when it is used on a function which returns a non-None result. (#10231)
  • twisted.internet.base.DelayedCall.__repr__ and twisted.internet.task.LoopingCall.__repr__ had the changes from #10155 reverted to accept non-function callables. (#10235)
  • Revert the removal of .whl building that was done as part of #10177. (#10236)
  • The type annotation of the host parameter to twisted.internet.interfaces.IReactorTCP.connectTCP has been corrected from bytes to str. (#10251)
  • Deprecated twisted.python.threading.ThreadPool.currentThread() in favor of threading.current_thread(). Switched twisted.python.threading.ThreadPool.currentThread() and twisted.python.threadable.getThreadID() to use `threading.current_thread()to avoid the deprecation warnings introduced forthreading.currentThread()`` in Python 3.10. (#10273)

Improved Documentation

  • twisted.internet.utils.runWithWarningsSupressed behavior of waiting on deferreds has been documented. (#10238)
  • Sync API docs templates with pydoctor 21.9.0 release, using new theming capabilities. (#10267)

Misc

Conch

Bugfixes

  • SSHTransportBase.ssh_KEXINIT now uses the remote peer preferred MAC list for negotiation. In previous versions it was only using the local preferred MAC list. (#10241)

Features


- twisted.conch.ssh now supports SSH extension negotiation (RFC 8308). ([#10266](https://github.com/twisted/twisted/issues/10266))

Bugfixes </tr></table>

... (truncated)

Commits
  • 45d463c move conch bugfix.
  • d48e4d3 Manually update the release version and date inside the NEWS file. T
  • 9ce5061 Update final release version.
  • 9d9322b Update the release notes.
  • 7e65fbe Bump copyright.
  • ddf72a9 tox -e towncrier
  • b33589f Update to 21.1.0.rc1
  • a033c84 Merge pull request #1685 from twisted/10293-conch-sftp-close-invalid-handle
  • 9e9cce2 Copy the skip logic from FileTransferCloseTests
  • 385e9f2 mention the name of the draft doc
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [twisted](https://github.com/twisted/twisted) from 21.7.0 to 22.1.0.
- [Release notes](https://github.com/twisted/twisted/releases)
- [Changelog](https://github.com/twisted/twisted/blob/trunk/NEWS.rst)
- [Commits](twisted/twisted@twisted-21.7.0...twisted-22.1.0)

---
updated-dependencies:
- dependency-name: twisted
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner February 11, 2022 03:53
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 11, 2022
@DMRobertson DMRobertson force-pushed the dependabot/pip/twisted-22.1.0 branch from 5abd59a to 08b348c Compare February 11, 2022 12:55
@DMRobertson DMRobertson removed the request for review from a team February 11, 2022 12:55
@DMRobertson DMRobertson marked this pull request as draft February 11, 2022 12:55
@DMRobertson DMRobertson self-assigned this Feb 11, 2022
@DMRobertson DMRobertson force-pushed the dependabot/pip/twisted-22.1.0 branch 3 times, most recently from 1d6c244 to 3e03d3d Compare February 11, 2022 13:05
@DMRobertson DMRobertson changed the base branch from main to dmr/dependabot-workflow February 11, 2022 13:06
@DMRobertson DMRobertson force-pushed the dmr/dependabot-workflow branch from 31eaf05 to b61b6d4 Compare February 11, 2022 13:07
@DMRobertson
Copy link
Contributor

@dependabot rebase

@DMRobertson DMRobertson force-pushed the dmr/dependabot-workflow branch 2 times, most recently from c412c19 to 88ebdc3 Compare February 11, 2022 13:12
@DMRobertson DMRobertson changed the base branch from dmr/dependabot-workflow to main February 11, 2022 13:12
@DMRobertson DMRobertson changed the base branch from main to dmr/dependabot-workflow February 11, 2022 13:13
@DMRobertson DMRobertson force-pushed the dependabot/pip/twisted-22.1.0 branch 2 times, most recently from 4c4551f to d918b01 Compare February 11, 2022 13:19
@DMRobertson DMRobertson changed the base branch from dmr/dependabot-workflow to main February 11, 2022 13:20
@DMRobertson DMRobertson force-pushed the dependabot/pip/twisted-22.1.0 branch 4 times, most recently from eb191fa to 87f771b Compare February 11, 2022 13:55
@DMRobertson DMRobertson changed the base branch from main to dmr/dependabot-workflow February 11, 2022 13:56
@DMRobertson DMRobertson force-pushed the dependabot/pip/twisted-22.1.0 branch 4 times, most recently from f0d29e0 to 1e59d6a Compare February 11, 2022 14:05
@DMRobertson DMRobertson force-pushed the dmr/dependabot-workflow-3 branch from 38b92cb to 0ec2310 Compare February 11, 2022 15:28
@DMRobertson DMRobertson changed the base branch from dmr/dependabot-workflow-3 to dbkr/v2 February 11, 2022 15:29
@DMRobertson DMRobertson changed the base branch from dbkr/v2 to main February 11, 2022 15:29
@DMRobertson DMRobertson changed the base branch from main to dmr/dependabot-workflow-3 February 11, 2022 15:29
@DMRobertson
Copy link
Contributor

https://github.com/dependabot rebase

@DMRobertson
Copy link
Contributor

@dependabot rebase

@DMRobertson DMRobertson force-pushed the dmr/dependabot-workflow-3 branch from e1f07a2 to 0ae672d Compare February 11, 2022 15:44
@DMRobertson DMRobertson changed the base branch from dmr/dependabot-workflow-3 to main February 11, 2022 15:45
@DMRobertson DMRobertson changed the base branch from main to dmr/dependabot-workflow-3 February 11, 2022 15:47
@DMRobertson DMRobertson force-pushed the dependabot/pip/twisted-22.1.0 branch from 934f564 to 3e03d3d Compare February 11, 2022 15:54
@DMRobertson
Copy link
Contributor

@dependabot recreate

2 similar comments
@DMRobertson
Copy link
Contributor

@dependabot recreate

@DMRobertson
Copy link
Contributor

@dependabot recreate

@DMRobertson DMRobertson force-pushed the dependabot/pip/twisted-22.1.0 branch from 559e4ba to 3e03d3d Compare February 11, 2022 16:44
@DMRobertson DMRobertson changed the base branch from dmr/dependabot-workflow-3 to main February 11, 2022 17:11
@DMRobertson DMRobertson force-pushed the dependabot/pip/twisted-22.1.0 branch from 158908d to 37e15f2 Compare February 11, 2022 17:17
@DMRobertson
Copy link
Contributor

Apologies for the messy history here. I was trying to get a workflow configured which would automatically write the changelog. Such a workflow would need write access, and I wanted to be ensure that a bad actor couldn't exploit this with a malicious PR (see also https://securitylab.github.com/research/github-actions-preventing-pwn-requests/).

It was simpler and good-enough to just suppress the check. I also removed the requirement that linting passes before running tests, because I don't think it makes a difference for a small project like this.

@DMRobertson DMRobertson removed their assignment Feb 11, 2022
@DMRobertson DMRobertson marked this pull request as ready for review February 11, 2022 17:27
@DMRobertson DMRobertson linked an issue Feb 11, 2022 that may be closed by this pull request
Comment on lines 11 to 13
if: >
(github.base_ref == 'main' || contains(github.base_ref, 'release-'))
&& github.event.pull_request.user.login != 'dependabot[bot]'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with these changes, but can we move them out into a separate PR? The title of this PR seems like it would hide this change in historical records.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled out into #498.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Though this will fail CI until that is merged)

@DMRobertson DMRobertson force-pushed the dependabot/pip/twisted-22.1.0 branch from 37e15f2 to 3e03d3d Compare February 14, 2022 18:39
@DMRobertson DMRobertson dismissed anoadragon453’s stale review February 15, 2022 13:33

After a rethink, manual changelog.

@DMRobertson DMRobertson removed the request for review from anoadragon453 February 15, 2022 13:35
@DMRobertson
Copy link
Contributor

I'm going to merge this as is. We've decided to manually add the changelog for now, and not worry about automating the process of adding a changelog. If we find ourselves inundated with updates from dependabot I can take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot PRs fail changelog check CI
2 participants