-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump twisted from 21.7.0 to 22.1.0 #495
Conversation
Bumps [twisted](https://github.com/twisted/twisted) from 21.7.0 to 22.1.0. - [Release notes](https://github.com/twisted/twisted/releases) - [Changelog](https://github.com/twisted/twisted/blob/trunk/NEWS.rst) - [Commits](twisted/twisted@twisted-21.7.0...twisted-22.1.0) --- updated-dependencies: - dependency-name: twisted dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
5abd59a
to
08b348c
Compare
1d6c244
to
3e03d3d
Compare
31eaf05
to
b61b6d4
Compare
@dependabot rebase |
c412c19
to
88ebdc3
Compare
4c4551f
to
d918b01
Compare
eb191fa
to
87f771b
Compare
f0d29e0
to
1e59d6a
Compare
38b92cb
to
0ec2310
Compare
@dependabot rebase |
e1f07a2
to
0ae672d
Compare
934f564
to
3e03d3d
Compare
@dependabot recreate |
559e4ba
to
3e03d3d
Compare
158908d
to
37e15f2
Compare
Apologies for the messy history here. I was trying to get a workflow configured which would automatically write the changelog. Such a workflow would need write access, and I wanted to be ensure that a bad actor couldn't exploit this with a malicious PR (see also https://securitylab.github.com/research/github-actions-preventing-pwn-requests/). It was simpler and good-enough to just suppress the check. I also removed the requirement that linting passes before running tests, because I don't think it makes a difference for a small project like this. |
.github/workflows/pipeline.yml
Outdated
if: > | ||
(github.base_ref == 'main' || contains(github.base_ref, 'release-')) | ||
&& github.event.pull_request.user.login != 'dependabot[bot]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with these changes, but can we move them out into a separate PR? The title of this PR seems like it would hide this change in historical records.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled out into #498.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Though this will fail CI until that is merged)
37e15f2
to
3e03d3d
Compare
After a rethink, manual changelog.
I'm going to merge this as is. We've decided to manually add the changelog for now, and not worry about automating the process of adding a changelog. If we find ourselves inundated with updates from dependabot I can take another look. |
Bumps twisted from 21.7.0 to 22.1.0.
Release notes
Sourced from twisted's releases.
... (truncated)
Changelog
Sourced from twisted's changelog.
... (truncated)
Commits
45d463c
move conch bugfix.d48e4d3
Manually update the release version and date inside the NEWS file. T9ce5061
Update final release version.9d9322b
Update the release notes.7e65fbe
Bump copyright.ddf72a9
tox -e towncrierb33589f
Update to 21.1.0.rc1a033c84
Merge pull request #1685 from twisted/10293-conch-sftp-close-invalid-handle9e9cce2
Copy the skip logic from FileTransferCloseTests385e9f2
mention the name of the draft docDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.