Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe how to install from source with poetry #505

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Conversation

DMRobertson
Copy link
Contributor

Fixes #504 ... hopefully. @richvdh could you confirm these instructions work for you?

@DMRobertson DMRobertson requested a review from a team as a code owner February 23, 2022 15:09
README.rst Outdated

Alternatively, Sydent can be installed using ``pip`` from a local git checkout::
Alternatively, Sydent can be installed using ``poetry`` from a local git checkout.
First [install `poetry`](https://python-poetry.org/docs/#installation), then::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nb this is RST, not markdown

Suggested change
First [install `poetry`](https://python-poetry.org/docs/#installation), then::
First `install Poetry <https://python-poetry.org/docs/#installation>`_, then::

@DMRobertson
Copy link
Contributor Author

DMRobertson commented Feb 23, 2022

Looks like I've borked the typechecking on develop.

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@DMRobertson
Copy link
Contributor Author

I think the typecheck should be fixed on main.

@DMRobertson DMRobertson merged commit b488a25 into main Feb 23, 2022
@DMRobertson DMRobertson deleted the dmr/poetry-readme branch February 23, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README contains confusing/misleading installation instructions
2 participants