Run tests even if newsfile step fails #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, if the newsfile step is skipped, then tests are also skipped. This happened on the `main` branch here: https://github.com/matrix-org/sydent/runs/5306840738?check_suite_focus=true
|
FWIW Synapse repo does something like this, while also not running the tests if the newsfile lint fails. Not entirely sure how, but its mentioned at https://github.com/matrix-org/synapse/blob/develop/.github/workflows/tests.yml#L51-L57 |
clokep
reviewed
Feb 24, 2022
|
Looks like there's a distinction between a step failing and a step being skipped. It's the newsfile check being skipped on |
|
I wonder if we can move those checks into the meta repo and re-use them? Not sure if that's possible though. |
erikjohnston
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, if the newsfile step is skipped, then tests are also skipped. This happened on the
mainbranch here:https://github.com/matrix-org/sydent/runs/5306840738?check_suite_focus=true