Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a 'done' job to the workflow. #509

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Add a 'done' job to the workflow. #509

merged 2 commits into from
Mar 7, 2022

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Mar 4, 2022 •
edited
Loading

My intention here is to turn on branch protection, in the same way that we have for Synapse, so that we get an auto-merge button in Github.

@richvdh richvdh marked this pull request as ready for review March 4, 2022 15:41
@richvdh richvdh requested a review from a team as a code owner March 4, 2022 15:41
@richvdh richvdh merged commit ff13916 into main Mar 7, 2022
@richvdh richvdh deleted the rav/done_action branch March 7, 2022 12:23
@DMRobertson
Copy link
Contributor

This seemed to fail on main because the changelog job was skipped: https://github.com/matrix-org/sydent/runs/5448116033?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squahtx squahtx squahtx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richvdh @DMRobertson @squahtx