Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly build resources in the HTTP server. #541

Merged
merged 5 commits into from
Dec 28, 2022
Merged

Directly build resources in the HTTP server. #541

merged 5 commits into from
Dec 28, 2022

Conversation

clokep
Copy link
Member

@clokep clokep commented Dec 22, 2022 •
edited
Loading

Instead of having a Servlets class and instantiating things in one file to just use them in another file, do it all at once.

Also removes a duplicate class.

@clokep clokep requested a review from a team as a code owner December 22, 2022 12:52
@clokep clokep mentioned this pull request Dec 22, 2022
Merged
richvdh
richvdh reviewed Dec 22, 2022
View reviewed changes
sydent/http/httpserver.py Show resolved Hide resolved
tests/test_blacklisting.py Outdated Show resolved Hide resolved
reivilibre
reivilibre approved these changes Dec 28, 2022
View reviewed changes
sydent/http/httpserver.py Outdated Show resolved Hide resolved
@clokep @reivilibre
Clarify comment.
fe9f7fc 
Co-authored-by: reivilibre <[email protected]>
@clokep clokep merged commit 9cb3681 into main Dec 28, 2022
@clokep clokep deleted the clokep/servlet-simplify branch December 28, 2022 12:47
@richvdh richvdh mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh left review comments

@reivilibre reivilibre reivilibre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clokep @richvdh @reivilibre