Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix poetry build #548

Merged
merged 5 commits into from
Feb 8, 2023
Merged

Fix poetry build #548

merged 5 commits into from
Feb 8, 2023

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Feb 8, 2023 •
edited
Loading

Fixes some the mistakes I made in merging #547 too quickly.

  1. Because there was no changelog, CI didn't run, so I would have seen the test failure. Fix this by not requiring changelogs on dependabot PRs.
  2. Dependabot seems to now be writing the new lockfile format (at least partially), so use Poetry 1.2.2, which understands this.
  3. Sneak in "only run CI on the latest commit" to be consistent with our other pipelines.
  4. The tests errored---something to do a call into pyOpenSSL. I tried updating that dependency and then the tests 🪄 magically passed.

Tested locally that the docker build succeeds.

@DMRobertson DMRobertson marked this pull request as ready for review February 8, 2023 13:24
@DMRobertson DMRobertson requested a review from a team as a code owner February 8, 2023 13:24
squahtx
squahtx approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DMRobertson DMRobertson merged commit 60d4148 into main Feb 8, 2023
@DMRobertson DMRobertson deleted the dmr/fix-poetry branch February 8, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squahtx squahtx squahtx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DMRobertson @squahtx