Fix a RuntimeWarning exception raised when calling ThreepidBinder._notify
without awaiting
#552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error occurred while informing a homeserver of a successful bind between a Matrix ID and a third-party ID, Sydent should log the error and retry the request to the homeserver.
Right now this is broken, and Sydent will raise a
RuntimeWarning
due toThreepidBinder._notify
not being await'd:This would call the request to never be retried as well, breaking reliability.
This PR fixes the call to
ThreepidBinder._notify
so that it is properly awaited viadefer.ensureDeferred
. Theself.sydent.reactor.callLater(...)
call is used for backing off purposes, and expects a Callable, not a Coroutine, hence the use of something likedefer.ensureDeferred
.