From 46c4b642945e9122ff69dc79b6c7d7533dad6962 Mon Sep 17 00:00:00 2001
From: David Robertson <davidr@element.io>
Date: Thu, 24 Feb 2022 14:25:38 +0000
Subject: [PATCH] Don't use `tox` for check-newsfragment

---
 .github/workflows/tests.yml    | 2 +-
 scripts-dev/check-newsfragment | 2 +-
 tox.ini                        | 7 -------
 3 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 4cb59dec04b3..1bc29c552fc6 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -49,7 +49,7 @@ jobs:
           ref: ${{ github.event.pull_request.head.sha }}
           fetch-depth: 0
       - uses: actions/setup-python@v2
-      - run: pip install tox
+      - run: "pip install 'towncrier>=18.6.0rc1'"
       - run: scripts-dev/check-newsfragment
         env:
           PULL_REQUEST_NUMBER: ${{ github.event.number }}
diff --git a/scripts-dev/check-newsfragment b/scripts-dev/check-newsfragment
index c764011d6adb..493558ad651b 100755
--- a/scripts-dev/check-newsfragment
+++ b/scripts-dev/check-newsfragment
@@ -35,7 +35,7 @@ CONTRIBUTING_GUIDE_TEXT="!! Please see the contributing guide for help writing y
 https://github.com/matrix-org/synapse/blob/develop/CONTRIBUTING.md#changelog"
 
 # If check-newsfragment returns a non-zero exit code, print the contributing guide and exit
-tox -qe check-newsfragment || (echo -e "$CONTRIBUTING_GUIDE_TEXT" >&2 && exit 1)
+python -m towncrier.check --compare-with=origin/develop || (echo -e "$CONTRIBUTING_GUIDE_TEXT" >&2 && exit 1)
 
 echo
 echo "--------------------------"
diff --git a/tox.ini b/tox.ini
index b5468d79ed03..04b972e2c58c 100644
--- a/tox.ini
+++ b/tox.ini
@@ -168,13 +168,6 @@ commands =
 extras = lint
 commands = isort -c --df {[base]lint_targets}
 
-[testenv:check-newsfragment]
-skip_install = true
-usedevelop = false
-deps = towncrier>=18.6.0rc1
-commands =
-   python -m towncrier.check --compare-with=origin/develop
-
 [testenv:combine]
 skip_install = true
 usedevelop = false