From ac3d44df0750fe3ada62de74bbc8662c55f8e17f Mon Sep 17 00:00:00 2001 From: Richard van der Hoff Date: Thu, 21 Jan 2021 11:49:22 +0000 Subject: [PATCH] Update out-of-date-comment https://github.com/matrix-org/synapse/pull/9189 makes this comment redundant. --- synapse/config/oidc_config.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/synapse/config/oidc_config.py b/synapse/config/oidc_config.py index ddabb61df53a..6c9fde9ce22f 100644 --- a/synapse/config/oidc_config.py +++ b/synapse/config/oidc_config.py @@ -44,10 +44,9 @@ def read_config(self, config, **kwargs): except DependencyException as e: raise ConfigError(e.message) from e - # check we don't have any duplicate idp_ids - # XXX: this won't detect clashes with other IdP providers using other SSO - # mechanisms (such as SAML or CAS); that will be detected when we set up the - # listeners but by then synapse will have forked, so it's not ideal. + # check we don't have any duplicate idp_ids now. (The SSO handler will also + # check for duplicates when the REST listeners get registered, but that happens + # after synapse has forked so doesn't give nice errors.) c = Counter([i.idp_id for i in self.oidc_providers]) for idp_id, count in c.items(): if count > 1: