Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

AS events should include prev_content field #11732

Closed
benparsons opened this issue Jan 12, 2022 · 1 comment · Fixed by #11798
Closed

AS events should include prev_content field #11732

benparsons opened this issue Jan 12, 2022 · 1 comment · Fixed by #11798
Labels
A-Application-Service Related to AS support good first issue Good for newcomers T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@benparsons
Copy link
Member

Description

AS spec states events should be "formatted as per the Client-Server API", but state events sent to ASes don't include the prev_content field.

Version information

Occurs as of 1.50.

Ref

Sayeth vdh:

ApplicationServiceTransactionWorkerStore.get_new_events_for_appservice is missing get_prev_content=True in its call to get_events_as_list
@H-Shay H-Shay added good first issue Good for newcomers T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jan 12, 2022
@totallynotvaishnav
Copy link
Contributor

Can I work on this issue?

@clokep clokep mentioned this issue Jan 21, 2022
Merged
4 tasks
@MadLittleMods MadLittleMods added the A-Application-Service Related to AS support label Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Application-Service Related to AS support good first issue Good for newcomers T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include prev_content field in AS events totallynotvaishnav/synapse
4 participants
@MadLittleMods @benparsons @H-Shay @totallynotvaishnav