Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Change latest_event format in thread bundled relationship #12085

Closed
germain-gg opened this issue Feb 25, 2022 · 2 comments · Fixed by #12090
Closed

Change latest_event format in thread bundled relationship #12085

germain-gg opened this issue Feb 25, 2022 · 2 comments · Fixed by #12090
Assignees
@clokep
Labels
A-Threads Threaded messages T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@germain-gg
Copy link
Contributor

We need to send down ClientEventWithoutRoomID rather than ClientEvent to be consistent with the event format that comes down /sync as discussed in the thread MSC
@germain-gg germain-gg mentioned this issue Feb 24, 2022
Merged
@richvdh
Copy link
Member

richvdh commented Feb 25, 2022

this may be happening already. Have you checked?

@clokep clokep added A-Threads Threaded messages T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Needs-Info This issue is blocked awaiting information from the reporter labels Feb 25, 2022
@clokep clokep self-assigned this Feb 25, 2022
@clokep
Copy link
Member

clokep commented Feb 25, 2022

Hm, I think we're not passing forward the event_format used to where we serialize this event. Should be straightforward.

This was referenced Feb 25, 2022
Merged
Closed
@clokep clokep mentioned this issue Apr 27, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
A-Threads Threaded messages T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the proper serialization format when bundling aggregations matrix-org/synapse
3 participants
@clokep @germain-gg @richvdh