This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add information on how the Synapse team does reviews. #13132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-Shay
approved these changes
Jun 30, 2022
babolivier
reviewed
Jul 4, 2022
babolivier
reviewed
Jul 4, 2022
docs/development/reviews.md
Outdated
| Team members should do the following when reviewing: | ||
|
|
||
| * Assigning themselves to the pull request; | ||
| * Review the pull request; |
There was a problem hiding this comment.
This second point feels a bit awkward: "Team members should review the pull request when reviewing"
There was a problem hiding this comment.
I didn't really want to get into "what to look for in a review" in this PR (since there are other conversations happening about that), so it is a bit terse.
Pretty much I want to say "now do the actual review".
There was a problem hiding this comment.
I reworded the section a bit, I hope it makes more sense now.
Co-authored-by: Andrew Morgan <[email protected]>
Co-authored-by: Brendan Abolivier <[email protected]>
Co-authored-by: Brendan Abolivier <[email protected]>
|
(Complement test failed, but this is docs only, so not going to restart it.) |
babolivier
approved these changes
Jul 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our discussion on this last week.