Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Faster joins: /messages should not block #13504

Open
richvdh opened this issue Aug 11, 2022 · 4 comments
Open

Faster joins: /messages should not block #13504

richvdh opened this issue Aug 11, 2022 · 4 comments
Labels
A-Federated-Join joins over federation generally suck O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@richvdh
Copy link
Member

richvdh commented Aug 11, 2022

Currently, attempts to backfill block until state resync completes. It would be nice if we had a partial-state equivalent for backfill, so that users can see history before the resync completes.
@squahtx
Copy link
Contributor

squahtx commented Aug 12, 2022

Do we need partial-state versions of /state_ids and /state too?
Otherwise I could see us spending as much time backfilling as it would take to do a full join of the room.

@richvdh
Copy link
Member Author

richvdh commented Aug 12, 2022

Do we need partial-state versions of /state_ids and /state too?

I think a partial-state version of /state_ids is the empty set? But yes, we can't just rely on the current implementation.

@richvdh
Copy link
Member Author

richvdh commented Aug 12, 2022

(of course, faster backfill is not inherently tied to faster joins - it's extending the "partial state" concept beyond joins and into backfill. As if it weren't already complicated enough.)

@H-Shay H-Shay added A-Federated-Join joins over federation generally suck T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. labels Aug 12, 2022
@squahtx squahtx added S-Minor Blocks non-critical functionality, workarounds exist. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 24, 2022
@kittykat kittykat mentioned this issue Oct 3, 2022
Closed
16 tasks
@richvdh
Copy link
Member Author

richvdh commented Oct 4, 2022 •
edited
Loading

This may end up being intertwined with other work on backfill which seeks to reduce the amount of state we need to download, such as #13618.

@squahtx squahtx mentioned this issue Nov 25, 2022
Closed
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Federated-Join joins over federation generally suck O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@richvdh @squahtx @H-Shay