This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Correct field name for stripped state events when knocking. knock_state_events -> knock_room_state
#14102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now support both the new and old field name.
anoadragon453
commented
Oct 7, 2022
Comment on lines
+800
to
+803
| raise KeyError( | ||
| "Missing 'knock_room_state' (or legacy 'knock_state_events') field in " | ||
| "send_knock response" | ||
| ) |
There was a problem hiding this comment.
I think a different exception type would be more appropriate (and user-friendly) here. But I'm inclined not to change things too much in this PR.
The earlier code would have also raised a KeyError in the case the field was not present.
squahtx
approved these changes
Oct 7, 2022
Good shout! #14151 |
|
I believe the CI failure is a flake as it seems entirely unrelated to the code changes. |
clokep
pushed a commit
that referenced
this pull request
Oct 12, 2022
…ate_events` -> `knock_room_state` (#14102)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14088.
This PR:
knock_room_statefield (new name), then aknock_state_eventsfield (old name) if present.