-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Allow filtering for admins in the list accounts admin API #16114
Conversation
f099d80
to
12abef8
Compare
filters.append("admin = 1") | ||
else: | ||
filters.append("admin = 0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside: I wonder if this was missed in #15515?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see the docs and docstring phrasing changed; everything else is a nice-to-have.
12abef8
to
e734acb
Compare
changelog.d/16114.feature
Outdated
@@ -0,0 +1 @@ | |||
Query-Parameter added to Admin-API /users to filter admins from user list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Query-Parameter added to Admin-API /users to filter admins from user list. | |
Add an `admins` query parameter to the [List Accounts](https://matrix-org.github.io/synapse/v1.91/admin_api/user_admin_api.html#list-accounts) [admin API](https://matrix-org.github.io/synapse/v1.91/usage/administration/admin_api/index.html), to include only admins or to exclude admins in user queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed the changelog earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have adopted the text.
Signed-off-by: Alexander Fechler <[email protected]>
e734acb
to
48feabf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm happy if CI is!
CI passed except for a flake on 48feabf, going to merge manually. |
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)