This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
502, 504 (and maybe 503) CONNECT proxy response codes should be treated as though they are direct connection failures
#16462
Labels
O-Uncommon
Most users are unlikely to come across this or unexpected workflow
S-Minor
Blocks non-critical functionality, workarounds exist.
T-Enhancement
New features, changes in functionality, improvements in performance, or user-facing enhancements.
Comments
reivilibre
added
S-Minor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
offshoot from #15883:
If a 502 or 504 is returned as the status code of the
CONNECTverb when proxying, Synapse should treat this as though it tried a connection itself and failed.It should not log a CRITICAL log line but the same kind of handling as e.g. a connection timeout or refused connection should be used.
We might want to extend support for this to 503 as a kind of quirk given that in #15883 the reporter's proxy software returned 503 instead (this seems incorrect to me but I suppose it'd be worth checking more generally).
The text was updated successfully, but these errors were encountered: