Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Refactor REST API tests to use explicit reactors #3351

Merged
merged 10 commits into from
Jul 17, 2018
Merged

Refactor REST API tests to use explicit reactors #3351

merged 10 commits into from
Jul 17, 2018

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented Jun 6, 2018

No description provided.

@hawkowl hawkowl force-pushed the hawkowl/first-pass-tests branch from b45554a to 2281b91 Compare June 28, 2018 10:20
@hawkowl hawkowl requested a review from a team June 28, 2018 10:26
@hawkowl hawkowl changed the title [WIP] First pass of direct HTTP server tests [WIP] Refactor REST API tests to use explicit reactors Jul 9, 2018
@hawkowl hawkowl changed the title [WIP] Refactor REST API tests to use explicit reactors Refactor REST API tests to use explicit reactors Jul 16, 2018
@hawkowl
Copy link
Contributor Author

hawkowl commented Jul 16, 2018

Before: 31816 lines, 16506 uncovered, 48%
After: 31817 lines, 16050 uncovered, 50%

erikjohnston
erikjohnston approved these changes Jul 17, 2018
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future it would be grand if this was split up into:

  • The change in infrastructure, possibly with an example in how it is used
  • The mass changes by rote

@hawkowl hawkowl merged commit bc006b3 into develop Jul 17, 2018
@hawkowl hawkowl deleted the hawkowl/first-pass-tests branch July 17, 2018 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawkowl @erikjohnston