This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Check the state of prev_events a bit more thoroughly when coming over federation #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. I've just had a thought: a server won't necessarily have permission to fetch state for events (e.g. if the server wasn't in the room at the time and history is private). I guess in the case where an event points to those prev events then we'll discard the event, but pick it up next time someone sends a message? |
|
I wonder whether we should drop the requirement that you need to be able to produce the prev_events? Given the server may not actually have permission to view the event? |
| ) | ||
| self.assertEqual(self.successResultOf(extrem)[0], "$join:test.serv") | ||
|
|
||
| @unittest.DEBUG |
There was a problem hiding this comment.
Was this meant to be left here?
There was a problem hiding this comment.
errrr no... but it probably doesn't harm anything for right now :)
erikjohnston
approved these changes
Jun 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.