This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Patch defer.inlineCallbacks to check logcontexts in tests #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(because travis doesn't let us see the logs)
richvdh
force-pushed
the
rav/patch_inline_callbacks
branch
from
c751ac2 to
8a325ae
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4205 +/- ##
========================================
Coverage 66.65% 66.65%
========================================
Files 299 299
Lines 29798 29798
Branches 4871 4871
========================================
Hits 19863 19863
Misses 8501 8501
Partials 1434 1434
Continue to review full report at Codecov.
|
erikjohnston
approved these changes
Dec 4, 2018
| import tests.patch_inline_callbacks | ||
|
|
||
| # attempt to do the patch before we load any synapse code | ||
| tests.patch_inline_callbacks.do_patch() |
There was a problem hiding this comment.
I wonder if we should print/log that we're replacing inlineCallbacks? Just so that if we accidentally end up importing the tests package there will be some indication that this has happened
There was a problem hiding this comment.
could do. I'm unconvinced such a warning would be noticed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty grim hack, but it helped me find a bunch of the issues fixed in #4204 / #4209 (on which this PR is based, otherwise it would fail CI). Hopefully the intention is clear. If anybody has any ideas for how to do it in a less awful fashion, I'd like to hear.